[ 
https://issues.apache.org/jira/browse/CASSANDRA-4554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545175#comment-13545175
 ] 

Vijay commented on CASSANDRA-4554:
----------------------------------

Just to clarify kind of lost, 
We are good with 0001 initially submitted and we can just ignore 0002?

{quote}
I'm not a fan of switching hints-in-progress to a Cache
{quote}
makeComputingMap is deprecated[1] hence made the cache, i can remove that from 
this patch, let me know.

[1] 
http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect/MapMaker.html#makeComputingMap(com.google.common.base.Function)
                
> Log when a node is down longer than the hint window and we stop saving hints
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-4554
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4554
>             Project: Cassandra
>          Issue Type: New Feature
>            Reporter: Jonathan Ellis
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: 0001-CASSANDRA-4554-add-hint-metrics.patch, 
> 0001-CASSANDRA-4554-logging-to-system-table-v2.patch, 
> 0002-CASSANDRA-4554-logging-to-system-table.patch
>
>
> We know that we need to repair whenever we lose a node or disk permanently 
> (since it may have had undelivered hints on it), but without exposing this we 
> don't know when nodes stop saving hints for a temporarily dead node, unless 
> we're paying very close attention to external monitoring.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to