[ 
https://issues.apache.org/jira/browse/CASSANDRA-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548758#comment-13548758
 ] 

Sylvain Lebresne commented on CASSANDRA-5137:
---------------------------------------------

I think you're right.

A fourth pseudo-solution could be to wait the end of the compaction to rename 
all the newly created writers (i.e remove the tmp markers). It's not 
bulletproof though as I don't think we can rename multiple files atomically but 
just wanted to mention it.

Maybe at least for 1.1, 3. is the best/simplest option. On the longer term, 
maybe 1. is better.
                
> Make sure SSTables left over from compaction get deleted and logged
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-5137
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5137
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.3
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 1.1.9, 1.2.1
>
>         Attachments: 5137-1.1.txt
>
>
> When opening ColumnFamily, cassandra checks SSTable files' ancestors and 
> skips loading already compacted ones. Those files are expected to be deleted, 
> but currently that never happens.
> Also, there is no indication of skipping loading file in the log, so it is 
> confusing especially doing upgradesstables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to