[ 
https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560671#comment-13560671
 ] 

Dave Brosius commented on CASSANDRA-4795:
-----------------------------------------

{quote}Since validateOptions is supposed to return a map of the options it 
don't know about, let's maybe check it's empty at the end of 
CFMetaData.validateCompactionOptions and get rid of the individual checks in 
Leveled and SizeTiered (which avoid needing VALID_OPTIONS).{quote}


If user supplied compaction strategies derive from these classes, that won't 
work.
                
> replication, compaction, compression? options are not validated
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-4795
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4795
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Brandon Williams
>            Assignee: Dave Brosius
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: 4795.compaction_strategy.txt, 
> 4795_compaction_strategy_v2.txt, 4795.replication_strategy.txt
>
>
> When creating a keyspace and specifying strategy options, you can pass any 
> k/v pair you like.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to