[
https://issues.apache.org/jira/browse/CASSANDRA-5034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569621#comment-13569621
]
Vijay edited comment on CASSANDRA-5034 at 2/2/13 6:55 PM:
----------------------------------------------------------
Hi Jonathan, The goal is to reject if the batch has a counters and triggers RM
(Some triggers might not return RM's) has to be applied using MutateAtomically.
We dont know if we have RM's from Triggers till we execute it, Currently we
dont know if we have counters in the List<RM> either....
The other option to iterate through the List and do instanceof which i think
will be more expensive than additional object. Plz let me know if you want to
go in the path i will close this and redo 1311.
was (Author: vijay2...@yahoo.com):
Hi Jonathan, The goal is to reject if the batch has a counters and triggers
RM has to be applied using MutateAtomically.
We dont know if we have RM's from Triggers till we execute it, Currently we
dont know if we have counters in the List<RM> either....
The other option to iterate through the List and do instanceof which i think
will be more expensive than additional object. Plz let me know if you want to
go in the path i will close this and redo 1311.
> Refactor to introduce Mutation Container in write path
> ------------------------------------------------------
>
> Key: CASSANDRA-5034
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5034
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 2.0
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 2.0
>
> Attachments: 0001-CASSANDRA-5034.patch
>
>
> For triggers we need to identify if the batch mutations contain counters, if
> present we cannot apply the BM with triggers safely. Hence we wanted this
> refactor, the idea is also to improve code reuse.
> https://github.com/Vijay2win/cassandra/blob/1311/src/java/org/apache/cassandra/thrift/MutationContainer.java
> We thought (reviewer: Gary) it is better to separate these 2 patches, hence
> this ticket.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
