[ 
https://issues.apache.org/jira/browse/CASSANDRA-5074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580725#comment-13580725
 ] 

Sylvain Lebresne commented on CASSANDRA-5074:
---------------------------------------------

In case that wasn't clear, I didn't said there is nothing to change. On the 
contrary, we should *stop* relying on setting the min/max compaction threshold 
to disable compaction (I'd be in favor of always considering that setting them 
to 0 is disallowed, but we'd have to leave that to 2.0 to not break it in a 
minor release). So instead I would add a per-cfs 'isAutoCompactionEnable' 
boolean. As for the call to isCompactionDisabled, it should indeed be moved, 
but I would move it to CompactionManager directly (where I would put 2 checks, 
one prior to submitting to the compaction executor, to avoid submitting useless 
task in the first place, and then again before the call to 
getNextBackgroundTask, just in case the runnable has been sitting for too long 
on the executor and has missed the first check).
                
> Add an official way to disable compaction
> -----------------------------------------
>
>                 Key: CASSANDRA-5074
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5074
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2.2
>
>
> We've traditionally used "min or max compaction threshold = 0" to disable 
> compaction, but this isn't exactly intuitive and it's inconsistently 
> implemented -- allowed from jmx, not allowed from cli.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to