[
https://issues.apache.org/jira/browse/CASSANDRA-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620374#comment-13620374
]
Carl Yeksigian commented on CASSANDRA-5403:
-------------------------------------------
LGTM; ship it :)
For reference, merged in trunk and pushed to
https://github.com/carlyeks/cassandra/tree/5403.
> Clean up ColumnFamily, ISortedColumns heirarchy
> -----------------------------------------------
>
> Key: CASSANDRA-5403
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5403
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 2.0
>
> Attachments: Screen Shot 2013-04-01 at 12.00.09 PM.png
>
>
> CF wraps ISC but adds no real functionality of its own (post-supercolumn
> cleanup).
> This means that we're wasting allocations every time we create a CF/ISC pair
> when really one would do.
> Other things that would be nice to clean up:
> # We often create an empty CF as a placeholder that should not be modified,
> and rely on convention to avoid such modification. We could enforce this
> with a new CF/ISC subclass.
> # Many places still use TMBSC where ABSC would be adequate and cheaper
> # Other places still (ModificationStatement; others?) would be fine using a
> column container with no sorting requirement at all
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
