[ 
https://issues.apache.org/jira/browse/CASSANDRA-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636734#comment-13636734
 ] 

Jonathan Ellis edited comment on CASSANDRA-5492 at 4/19/13 7:55 PM:
--------------------------------------------------------------------

Pushed to http://github.com/jbellis/cassandra/commits/5492-2

Second commit adds ScrubTest back, minus testScrubFile that appears to have 
relied on a bogus bloom filter, which is now skipped on the read path.

Note that the first commit cleans up the IndexHelper cruft added in 
CASSANDRA-5385.
                
      was (Author: jbellis):
    Pushed to github.com/jbellis/cassandra/commits/5492-2

Second commit adds ScrubTest back, minus testScrubFile that appears to have 
relied on a bogus bloom filter, which is now skipped on the read path.

Note that the first commit cleans up the IndexHelper cruft added in 
CASSANDRA-5385.
                  
> Backport row-level bloom filter removal to 1.2
> ----------------------------------------------
>
>                 Key: CASSANDRA-5492
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5492
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2.5
>
>
> With the possible presence of range tombstones, it is erroneous to skip 
> checking for a given column in SSTableNamesIterator because the bloom filter 
> says it is not there.
> This is fixed by CASSANDRA-5487, which ignores the BF, but it's a shame to 
> leave unused bloom filters cluttering up the row cache.
> If it's too risky to do a full backport we can just substitute an 
> AlwaysPresentFilter in RIE.create, but I think the code removal is fairly 
> straightforward.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to