[ 
https://issues.apache.org/jira/browse/CASSANDRA-5349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640448#comment-13640448
 ] 

Sylvain Lebresne commented on CASSANDRA-5349:
---------------------------------------------

Wonder if it wouldn't be worth to put the new values at the end of the message, 
after the consistency level? That way, we could make that last part optional 
(i.e. the server would check whether there is remaining bytes to read after the 
CL). The 2 small advantages would be that 1) if you don't have bind variables, 
we could save the short encoding the number of values and 2) would made it 
marginally easier on the client if they want to support both v1 and v2 (as in 
the case of no binding variables, they don't have to bother about which version 
is in use). Not huge pros, but if there is no cons...

Nit:
* we can have the old QP.process() call the new one with an empty list.
                
> Add binary protocol support for bind variables to non-prepared statements
> -------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5349
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5349
>             Project: Cassandra
>          Issue Type: Task
>          Components: API
>    Affects Versions: 1.2.0
>            Reporter: Jonathan Ellis
>            Assignee: Marcus Eriksson
>            Priority: Minor
>              Labels: cql, protocol
>             Fix For: 2.0
>
>         Attachments: 
> 0001-CASSANDRA-5349-binary-protocol-support-for-binding-v.patch, 
> 0001-CASSANDRA-5349.patch
>
>
> Currently, the binary protocol allows requests as "string" or "[prepared 
> statement] id + bind vars".  Allowing "string + bind vars" as well would 
> simplify life for users with one-off statements and not have to choose 
> between adding boilerplate for PS, and having to manually escape parameters, 
> which is particularly painful for binary data.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to