[ https://issues.apache.org/jira/browse/CASSANDRA-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13640747#comment-13640747 ]
Jonathan Ellis commented on CASSANDRA-5051: ------------------------------------------- bq. How will this work if someone needs to change snitch/RF? I don't see a problem, but I could be missing something subtle. Here are the three scenarios I see: # You expand a replica set to new nodes. This doesn't affect you since there is never "data that used to belong but now does not anymore." # You reduce the replica set. This saves you from having to run cleanup but I don't see why you might want to stop it from doing that. # You reduce the replica set temporarily, knowing that you're going to re-expand it. Here it might look like you could save time by preventing the cleanup, but Cassandra doesn't actually know that "I used to be responsible for some of this data" and will re-stream the entire range anyway. > Allow automatic cleanup after gc_grace > -------------------------------------- > > Key: CASSANDRA-5051 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5051 > Project: Cassandra > Issue Type: New Feature > Components: Core > Reporter: Brandon Williams > Assignee: Vijay > Labels: vnodes > Fix For: 2.0 > > Attachments: 0001-5051-v4.patch, 0001-5051-v6.patch, > 0001-5051-with-test-fixes.patch, 0001-CASSANDRA-5051.patch, > 0002-5051-remove-upgradesstable.patch, > 0002-5051-remove-upgradesstable-v4.patch, 0004-5051-additional-test-v4.patch, > 5051-v2.txt > > > When using vnodes, after adding a new node you have to run cleanup on all the > machines, because you don't know which are affected and chances are it was > most if not all of them. As an alternative to this intensive process, we > could allow cleanup during compaction if the data is older than gc_grace (or > perhaps some other time period since people tend to use gc_grace hacks to get > rid of tombstones.) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira