[ 
https://issues.apache.org/jira/browse/CASSANDRA-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646583#comment-13646583
 ] 

Jonathan Ellis commented on CASSANDRA-5521:
-------------------------------------------

As Pavel notes, the most important use of getKey is the one in binarySearch.  
But here we only care about the comparison, we don't actually need the artifact 
of a ByteBuffer.  So why not compare directly without creating a buffer first?  
No buffer at all is even cheaper than a native buffer.

(This would also mean that we only need to look at as many bytes as it takes 
before the first difference is found.)
                
> move IndexSummary off heap
> --------------------------
>
>                 Key: CASSANDRA-5521
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5521
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Vijay
>             Fix For: 2.0
>
>
> IndexSummary can still use a lot of heap for narrow-row sstables.  (It can 
> also contribute to memory fragmentation because of the large arrays it 
> creates.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to