[ 
https://issues.apache.org/jira/browse/CASSANDRA-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647264#comment-13647264
 ] 

Vijay edited comment on CASSANDRA-5521 at 5/2/13 4:09 AM:
----------------------------------------------------------

Honestly, glad to see the thread going in the same thinking process which i 
went though.... 

Changing the Partitioner is a bigger change... but before we go there, 
wondering if this optimization is going to help us? 
For BB is not cheap, but it is going to be good garbage which will live and die 
in young generation.

I can think of 2 other options...
1) We can serialize and deserialize Token in IndexSummary we still need 
additional function to serialize and deserialize from memory (for BOP we can 
serialize the key/byte[], we have also removed the token calculation overhead) 
so we can also try and compare incrementally.
2) We can use MMappedFile instead and get ByteBuffer (this could work in our 
favor, for the new SST's which is never queried there is zero overhead in 
memory ) :)
                
      was (Author: vijay2...@yahoo.com):
    Honestly, glad to see the thread going in the same thinking process which i 
went though.... 

Changing the Partitioner is a bigger change... before we go there, wondering if 
this optimization is going to help us? 
For BB is not cheap, but it is going to be good garbage which will live and die 
in young generation.

I can think of 2 other options...
1) We can serialize and deserialize Token in IndexSummary for RP (for BOP we 
can serialize the key/byte[]) so we can compare incrementally too (taking the 
hit during flush)
2) We can use MMappedFile instead and get ByteBuffer (this could work in our 
favor, for the new SST's which is never queried there is zero overhead in 
memory ) :)
                  
> move IndexSummary off heap
> --------------------------
>
>                 Key: CASSANDRA-5521
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5521
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Vijay
>             Fix For: 2.0
>
>
> IndexSummary can still use a lot of heap for narrow-row sstables.  (It can 
> also contribute to memory fragmentation because of the large arrays it 
> creates.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to