[ 
https://issues.apache.org/jira/browse/CASSANDRA-5555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665977#comment-13665977
 ] 

Dave Brosius edited comment on CASSANDRA-5555 at 5/24/13 3:50 AM:
------------------------------------------------------------------

A premature patch added to see if approach is relatively ok, haven't formulated 
tests yet, so *definitely* not ready yet.

Also note that this implementation leaks into StorageService, which is probably 
not desired, and a real fix probably wants a separate interface into 
SSTableLoader.stream() as opposed to a complete replace. But not sure.
                
      was (Author: dbrosius):
    A premature patch added to see if approach is relatively ok, haven't 
formulated tests yet, so *definitely* not ready yet.

Also not that this implementation leaks into StorageService, which is probably 
not desired, and a real fix probably wants a separate interface into 
SSTableLoader.stream() as opposed to a complete replace. But not sure.
                  
> Allow sstableloader to handle a larger number of files
> ------------------------------------------------------
>
>                 Key: CASSANDRA-5555
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5555
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Tyler Hobbs
>            Assignee: Dave Brosius
>             Fix For: 1.2.6
>
>         Attachments: 5555-01.txt
>
>
> With the default heap size, sstableloader will OOM when there are roughly 25k 
> files in the directory to load.  It's easy to reach this number of files in a 
> single LCS column family.
> By avoiding creating all SSTableReaders up front in SSTableLoader, we should 
> be able to increase the number of files that sstableloader can handle 
> considerably.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to