[ 
https://issues.apache.org/jira/browse/CASSANDRA-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712132#comment-13712132
 ] 

Sylvain Lebresne commented on CASSANDRA-5542:
---------------------------------------------

One last nit: In ConnectionHandler.sendMessage(), I don't like throwing 
messages on the floor without warning. I'd rather add some 
isOutgoingConnected() method in ConnectionHandler and have the caller check 
that before calling sendMessage. And otherwise, sendMessage() would throw a 
RuntimeException in that case too.

But other than that, lgtm, ship it!
                
> BulkLoader is broken in trunk
> -----------------------------
>
>                 Key: CASSANDRA-5542
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5542
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 2.0 beta 1
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>             Fix For: 2.0 beta 2
>
>         Attachments: 0001-change-streaming-procedure.patch, 
> 0002-make-BulkLoader-work-with-SSTableReader.patch, 
> 0003-update-for-post-CASSANDRA-5171.patch, 5542-fix-NPE.txt, 5542.txt
>
>
> After CASSANDRA-5015 and CASSANDRA-5521, we need CFMetaData to open 
> SSTable(Reader), especially to get bloom_filter_fp_chance and index_interval.
> When using bulkloader, CFMetaData is not available, so we cannot open SSTable 
> to be streamed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to