[ https://issues.apache.org/jira/browse/CASSANDRA-5774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13715303#comment-13715303 ]
Jonathan Ellis commented on CASSANDRA-5774: ------------------------------------------- Do we need a mutable map in the CFDefinition copies? Should probably move the to/from/deleteFrom Schema code into SystemTable for consistency. Would prefer to split the ColumnDefinition cleanup (others?) to a separate commit, ninja is fine. Otherwise LGTM. > Fix system.schema_triggers-related trigger/schema issues > -------------------------------------------------------- > > Key: CASSANDRA-5774 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5774 > Project: Cassandra > Issue Type: Bug > Affects Versions: 2.0 beta 1 > Reporter: Aleksey Yeschenko > Assignee: Aleksey Yeschenko > Priority: Minor > Labels: triggers > Fix For: 2.0 > > Attachments: 5774.txt > > > Among other things, the patch does the following: > - adds missing schema_triggers to MigrationManager.resetLocalSchema() > - adds missing schema_triggers to SystemKeyspace.serializeSchema() - so that > triggers would be part of schema version calculation > - adds missing schema_triggers to DefsTables.flushSchemaCFs() > - adds missing triggers to CFMetaData.toSchema(), so that CFs created via > thrift with triggers from the beginning would serialize triggers > - removes triggers from CFMetaData.newIndexMetadata(), so that 2i CFs > wouldn't inherit the triggers from the parent CF > There are other minor and not so minor changes, but these were the most > critical ones. The patch also (unnecessarily) cleans up ColumnDefinition, but > that was done to make it consistent with the new TriggerDefinition class. > The bulk of the patch is the updated thrift-gen files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira