[ https://issues.apache.org/jira/browse/CASSANDRA-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718111#comment-13718111 ]
Sam Tunnicliffe edited comment on CASSANDRA-5614 at 7/25/13 8:59 AM: --------------------------------------------------------------------- I realised I'd missed the case where the timestamp on a column is greater than the RT's max, so attaching a fourth patch which handles that. My github branch is https://github.com/beobal/cassandra/tree/5614 was (Author: beobal): I realised I'd missed the case where columns are added after a RT, so attaching a fourth patch which handles that. My github branch is https://github.com/beobal/cassandra/tree/5614 > W/O specified columns ASPCSI does not get notified of deletes > ------------------------------------------------------------- > > Key: CASSANDRA-5614 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5614 > Project: Cassandra > Issue Type: Bug > Affects Versions: 1.2.0 > Reporter: Benjamin Coverston > Assignee: Sam Tunnicliffe > Priority: Minor > Fix For: 1.2.7 > > Attachments: > 0001-CASSANDRA-5614-PreCompactedRow-updates-2i-correctly.patch, > 0002-CASSANDRA-5614-LazilyCompactedRow-outputs-SSTables-a.patch, > 0003-CASSANDRA-5614-Memtable-updates-with-RowTombstone-up.patch, > 0004-CASSANDRA-5614-Consider-timestamps-when-checking-col.patch > > > I'm working on a secondary index implementation based on the composite index > type. > AbstractSimplePerColumnSecondaryIndex.java#delete is not called when CQL > delete statements do not specify columns. > When I specify columns it is called. Pretty sure this is a bug. > Setup: > {code} > cqlsh> create KEYSPACE foo WITH replication = {'class': 'SimpleStrategy' , > 'replication_factor': 1}; > cqlsh> use foo; > cqlsh:foo> CREATE TABLE albums (artist text, album text, rating int, release > int, PRIMARY KEY (artist, album)); > cqlsh:foo> CREATE INDEX ON albums (rating); > {code} > {code} > cqlsh:foo> insert into albums (artist, album, rating, release) VALUES > ('artist', 'album', 1, 2); > {code} > Does not get called here: > {code} > cqlsh:foo> DELETE FROM albums where artist='artist' and album='album'; > {code} > {code} > cqlsh:foo> insert into albums (artist, album, rating, release) VALUES > ('artist', 'album', 1, 2); > {code} > gets called here: > {code} > cqlsh:foo> DELETE rating FROM albums where artist='artist' and album='album'; > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira