[
https://issues.apache.org/jira/browse/CASSANDRA-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723436#comment-13723436
]
Jason Brown edited comment on CASSANDRA-5823 at 7/30/13 5:56 AM:
-----------------------------------------------------------------
bq. It seems we are starting to litter user's home directory with files...
Yup, I'm down with this. Couple of questions:
* Timing - Assuming it only takes a day or two for me to put this together, are
we fine with adding this to both 1.2 and 2.0? Seems reasonably low risk to
include it in both, but I'm open to debate.
* Previous history files - do we care about preserving existing history files
(cli, cqlsh, and so on)? Might be more of a hassle to locate previous files and
move them rather than start fresh with the new locations. The worst that
happens is you lose a little bit of command history (from the application); if
you desperately needed to recover an executed command from history, the
previous files would be lying around. EDIT: maybe retaining history isn't so
bad, I'm on the fence.
* ~/.cassandra.in.sh - should we add an extra path the $CASSANDRA_INCLUDE for
the start scripts to look in the new ~/.cassandra dir, before checking the home
dir itself?
bq. It appears this logs all nodetool commands whether they parse correctly or
not
My thought here was to capture as much as parsed correctly from the arguments
(not accept pure garbage), but capture 'fat-fingered' mistakes so you can see
those in the future to attempt to figure out why your 'reapir' didn't work (in
this case, because you needed to spell 'repair' correctly). I'm game to moving
it later though.
bq. try-with-resources
Sure, I can do that; will need to do a little homework first ;)
was (Author: jasobrown):
bq. It seems we are starting to litter user's home directory with files...
Yup, I'm down with this. Couple of questions:
* Timing - Assuming it only takes a day or two for me to put this together, are
we fine with adding this to both 1.2 and 2.0? Seems reasonably low risk to
include it in both, but I'm open to debate.
* Previous history files - do we care about preserving existing history files
(cli, cqlsh, and so on)? Might be more of a hassle to locate previous files and
move them rather than start fresh with the new locations. The worst that
happens is you lose a little bit of command history (from the application); if
you desperately needed to recover an executed command from history, the
previous files would be lying around. Plus, ditching the previous files would
be faster to code :)
* ~/.cassandra.in.sh - should we add an extra path the $CASSANDRA_INCLUDE for
the start scripts to look in the new ~/.cassandra dir, before checking the home
dir itself?
bq. It appears this logs all nodetool commands whether they parse correctly or
not
My thought here was to capture as much as parsed correctly from the arguments
(not accept pure garbage), but capture 'fat-fingered' mistakes so you can see
those in the future to attempt to figure out why your 'reapir' didn't work (in
this case, because you needed to spell 'repair' correctly). I'm game to moving
it later though.
bq. try-with-resources
Sure, I can do that; will need to do a little homework first ;)
> nodetool history logging
> ------------------------
>
> Key: CASSANDRA-5823
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5823
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jason Brown
> Assignee: Jason Brown
> Priority: Minor
> Fix For: 1.2.8, 2.0 rc1
>
> Attachments: 5823-v1.patch
>
>
> Capture the commands and time executed from nodetool into a log file, similar
> to the cli.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
