[ https://issues.apache.org/jira/browse/CASSANDRA-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727787#comment-13727787 ]
Tyler Hobbs commented on CASSANDRA-4573: ---------------------------------------- [~xedin] that looks good to me. There's one problem with the patch: you changed the cassandra.yaml default to {{hsha}}; other than that, +1. > HSHA doesn't handle large messages gracefully > --------------------------------------------- > > Key: CASSANDRA-4573 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4573 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Tyler Hobbs > Assignee: Pavel Yaskevich > Fix For: 2.0 > > Attachments: CASSANDRA-4573.patch, > disruptor-thrift-server-0.2.2-SNAPSHOT.jar, repro.py > > > HSHA doesn't seem to enforce any kind of max message length, and when > messages are too large, it doesn't fail gracefully. > With debug logs enabled, you'll see this: > {{DEBUG 13:13:31,805 Unexpected state 16}} > Which seems to mean that there's a SelectionKey that's valid, but isn't ready > for reading, writing, or accepting. > Client-side, you'll get this thrift error (while trying to read a frame as > part of {{recv_batch_mutate}}): > {{TTransportException: TSocket read 0 bytes}} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira