[ 
https://issues.apache.org/jira/browse/CASSANDRA-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733952#comment-13733952
 ] 

Jonathan Ellis commented on CASSANDRA-5862:
-------------------------------------------

Radim: hardware CRC32C is exactly what Jake tested above.

Jake: the dual checksum fields in CRAR are a bit clunky; the approach of 
instantiating the correct one in the constructor that you use in CIS is cleaner.

Nit: if we can come up with a single name to represent "adler and 
post-compression" then I'd prefer that to passing two booleans around that are 
always the same value.

Otherwise LGTM.
                
> Switch to adler checksum for sstables
> -------------------------------------
>
>                 Key: CASSANDRA-5862
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5862
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: T Jake Luciani
>             Fix For: 2.0.1
>
>         Attachments: 5862.txt
>
>
> Adler is significantly faster than CRC32: 
> http://java-performance.info/java-crc32-and-adler32/
> (Adler is weaker for short inputs, so we should leave the commitlog alone, as 
> it checksums each mutation individually.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to