[ 
https://issues.apache.org/jira/browse/CASSANDRA-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788416#comment-13788416
 ] 

Carl Yeksigian commented on CASSANDRA-4809:
-------------------------------------------

Sorry, missed the question before.

Overall, the proposed updates to the patch look good (I had forgotten about the 
low quality of the first patch -- done during a meetup). I'm wondering why the 
keyspace checks have been moved inside of the loop, but the control flow is 
still a return. Seems like either we can check it once before the loop and exit 
the method, or we continue instead of return if we want to check each mutation.

> Allow restoring specific column families from archived commitlog
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-4809
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4809
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Nick Bailey
>            Assignee: Lyuben Todorov
>              Labels: lhf
>             Fix For: 2.0.2
>
>         Attachments: 4809.patch, 4809__v2.patch
>
>
> Currently you can only restore the entire contents of a commit log archive. 
> It would be useful to specify the keyspaces/column families you want to 
> restore from an archived commitlog.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to