[ 
https://issues.apache.org/jira/browse/CASSANDRA-5695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794368#comment-13794368
 ] 

Brandon Williams commented on CASSANDRA-5695:
---------------------------------------------

Nice job, this looks great.  My only suggestion would be that we exercise more 
types in CqlStorage, since historically converting types has been problematic 
(and that's why CassandraStorage tries to touch them all.)  We can do that in a 
different ticket if you'd prefer, in which case I'll go ahead and commit this.

> Convert pig smoke tests into real PigUnit tests
> -----------------------------------------------
>
>                 Key: CASSANDRA-5695
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5695
>             Project: Cassandra
>          Issue Type: Test
>          Components: Hadoop
>            Reporter: Brandon Williams
>            Assignee: Alex Liu
>            Priority: Minor
>             Fix For: 2.0.2
>
>         Attachments: 5695-1.2-branch.txt
>
>
> Currently, we have some ghetto pig tests in examples/pig/test, but there's 
> currently no way to continuously integrate these since a human needs to check 
> that the output isn't wrong, not just that the tests ran successfully.  We've 
> had garbled output problems in the past, so it would be nice to formalize our 
> tests to catch this.  PigUnit appears to be a good choice for this.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to