[ 
https://issues.apache.org/jira/browse/CASSANDRA-6456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lyuben Todorov updated CASSANDRA-6456:
--------------------------------------

    Attachment: 6456_v4_trunk.patch

Patch is technically good but there are some minor nits: 
- Space needed after try at YamlConfigurationLoader#loadConfig() - 
{{try(InputStream is = url.openStream())}}
- Imports need to be cleaned up in YamlConfigurationLoader and CassandraDaemon 
(see [Cody Style - Imports|http://wiki.apache.org/cassandra/CodeStyle#imports])
- Catch needs to go on a new line in {{CassaraDaemon#setup()}}

Attaching V4 with the above nits addressed, and +1 from me. 


> log listen address at startup
> -----------------------------
>
>                 Key: CASSANDRA-6456
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6456
>             Project: Cassandra
>          Issue Type: Wish
>          Components: Core
>            Reporter: Jeremy Hanna
>            Assignee: Sean Bridges
>            Priority: Trivial
>         Attachments: 6456_v4_trunk.patch, CASSANDRA-6456-2.patch, 
> CASSANDRA-6456-3.patch, CASSANDRA-6456.patch
>
>
> When looking through logs from a cluster, sometimes it's handy to know the 
> address a node is from the logs.  It would be convenient if on startup, we 
> indicated the listen address for that node.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to