[ https://issues.apache.org/jira/browse/CASSANDRA-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13931557#comment-13931557 ]
Sylvain Lebresne commented on CASSANDRA-6745: --------------------------------------------- Mostly look good to me, though one last point is that since the new ''caching" syntax beaks the existing one, I think we'd need to still support the old syntax too at least for 2.1 (in CQL3 I mean), with maybe a warning in the log if said old syntax is used. Otherwise this could be annoying for rolling upgrades. Another nit is that I'd leave CQL2 alone. It will be removed in 3.0 so the only thing someone that still use CQL2 in 2.1 is update to CQL3. So changing the syntax of "caching" there would just be an annoyance, and I wouldn't even bother with supporting the new syntax: again, if you want to use the new caching features and you're on CQL2, it's high time for you to upgrade to CQL3. > Require specifying rows_per_partition_to_cache > ---------------------------------------------- > > Key: CASSANDRA-6745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6745 > Project: Cassandra > Issue Type: Bug > Reporter: Jonathan Ellis > Assignee: Marcus Eriksson > Priority: Trivial > Fix For: 2.1 beta2 > > Attachments: 0001-wip-caching-options.patch > > > We should require specifying rows_to_cache_per_partition for new tables or > newly ALTERed when row caching is enabled. > Pre-upgrade should be grandfathered in as ALL to match existing semantics. -- This message was sent by Atlassian JIRA (v6.2#6252)