[ https://issues.apache.org/jira/browse/CASSANDRA-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968010#comment-13968010 ]
Aleksey Yeschenko commented on CASSANDRA-6985: ---------------------------------------------- Dunno. Doesn't make sense to me to start with small steps when you don't know where the destination is. The API itself might change a lot once you de-singletonise it, so this change could be pointless. A commit should be self-contained. This one, by itself, makes very little sense and only confuses things ("why are they passing singletons as arguments?"). We can wait for one large no-singleton commit - there is no rush for 3.0. > ReadExecutors should not rely on static StorageProxy > ---------------------------------------------------- > > Key: CASSANDRA-6985 > URL: https://issues.apache.org/jira/browse/CASSANDRA-6985 > Project: Cassandra > Issue Type: Sub-task > Reporter: Edward Capriolo > Assignee: Edward Capriolo > Priority: Minor > Fix For: 3.0 > > Attachments: CASSANDRA_6985.1.patch > > > All the Read Executor child classes require use of the Storage Proxy to carry > out read. We can pass the StorageProxy along in the constructor. -- This message was sent by Atlassian JIRA (v6.2#6252)