[ 
https://issues.apache.org/jira/browse/CASSANDRA-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973806#comment-13973806
 ] 

Sergio Bossa commented on CASSANDRA-7047:
-----------------------------------------

That was definitely intentional.

This patch is not meant to have any functional impact, so TriggersTest result 
will be the same with or without it, as it only tests the end result of 
mutations being stored or not. TriggerExecutorTest is instead a true unit test, 
as it tests the mutations produced by the two execute() methods (hence the 
different style).

I can merge the two, but I think that would be the wrong thing.

> TriggerExecutor should group mutations by row key
> -------------------------------------------------
>
>                 Key: CASSANDRA-7047
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7047
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Sergio Bossa
>            Assignee: Sergio Bossa
>         Attachments: 7047-v2.txt, CASSANDRA-7047.patch
>
>
> TriggerExecutor doesn't currently group mutations returned by triggers even 
> if belonging to the same row key: while harmful per se (at least, I think 
> so), this is definitely a performance problem, because each mutation is a 
> *cluster* mutation, generating more network traffic, more disk IO and more 
> index calls (if present).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to