[ 
https://issues.apache.org/jira/browse/CASSANDRA-7255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003649#comment-14003649
 ] 

Sylvain Lebresne commented on CASSANDRA-7255:
---------------------------------------------

bq. 'cleanranges' requires cassandra knowledge that would prevent this problem 
to begin with

But at least it's less likely that someone will think it's cleaning up 
tombstones (and we can probably go with something even more specific like 
cleantokenranges). I don't think it's about having completely new user figure 
out what it does precisely just by the name, but rather avoid that people would 
think it does something it doesn't because the name is too generic. I can buy 
that "cleanup" is too generic on that front (but I agree 'trim' is not 
particularly better).

That said, the one downside of changing it is that it might break existing user 
scripts and require fixing all docs (which will likely generate more confusion 
than it will fix at least in the short term). I don't have a very strong 
opinion on whether the benefits of a name change outweighs those initial 
downsides however.

> Rename nodetool cleanup
> -----------------------
>
>                 Key: CASSANDRA-7255
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7255
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Tyler Hobbs
>            Priority: Trivial
>
> A lot of cassandra users seem to think nodetool cleanup does all kinds of 
> things that it doesn't.   For example, you'll find a lot of quotes like this 
> in IRC and on the mailing list:
> bq. you need to run 'nodetool cleanup' to make sure all tombstones are deleted
> Renaming it to something clearer could help cut down on the confusion.  
> Perhaps "nodetool cleanranges" or "nodetool trim".



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to