[ 
https://issues.apache.org/jira/browse/CASSANDRA-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042365#comment-14042365
 ] 

Mike Adamson commented on CASSANDRA-7439:
-----------------------------------------

I agree but I raised this so that maybe someone could sanity check those places 
where it isn't checked because there doesn't seem to be a clear separation 
between instances where the return value is null checked and instances where it 
isn't checked.

> There are a number of places where 
> Gossiper.instance.getEndpointStateForEndpoint is not checked for null
> --------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-7439
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7439
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Mike Adamson
>            Priority: Minor
>
> In most places the getEndpointStateForEndpoint method is null checked but in 
> a number of places it isn't.
> Without testing each individual call point it is difficult to tell from the 
> context whether the state will be null or not.
> In this case wouldn't it make sense to null every call to this method to 
> avoid race conditions and NPEs



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to