[
https://issues.apache.org/jira/browse/CASSANDRA-6146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048601#comment-14048601
]
Benedict edited comment on CASSANDRA-6146 at 7/1/14 7:43 AM:
-------------------------------------------------------------
It looks like I heavily overestimated how much of the changes were down to
package moves, or under estimated how much I overhauled stress. I've rebased
into 4 commits: jake's patch, package movements, deletion of old functionality,
then the guts of the refactor. The last step is still a pretty significant
chunk of changes (~2.5k +/-), and primarily revolves around the introduction of
the concept of PartitionGenerator and SeedGenerator (and removal of the old
RowGen/KeyGen), which subtly changes program flow pretty much everywhere.
There's also the parallel introduction of OpDistribution which requires some
annoying changes in the settings hierarchy, but simplifies the changes
necessary outside to support mixed operations of both the old and new kind.
* ~0.8k +/- goes on in generate, which are pretty trivial changes;
* ~0.6k are refactoring the old operations to use the new generators, and is
mostly straightforward; primarily it involves the introduction of a new
PredefinedOperation class, and rewiring the old classes to use its slightly
different methods
* ~.2k are refactoring the new insert/read statements to share the same common
superclass, and use the new partition generator;
* ~.7k are in the settings classes, and are probably the most annoying changes
to review, but also not super important
* the remainder are in the base classes Operation, StressAction and
StressProfile
If this is too painful, I'll see what can be done to split the patch out
further.
Branch can be found
[here|https://github.com/belliottsmith/cassandra/commits/6146-cqlstress-inc]
was (Author: benedict):
It looks like I heavily overestimated how much of the changes were down to
package moves, or under estimated how much I overhauled stress. I've rebased
into 4 commits: jake's patch, package movements, deletion of old functionality,
then the guts of the refactor. The last step is still a pretty significant
chunk of changes (~2.5k +/-), and primarily revolves around the introduction of
the concept of PartitionGenerator and SeedGenerator (and removal of the old
RowGen/KeyGen), which subtly changes program flow pretty much everywhere.
There's also the parallel introduction of OpDistribution which requires some
annoying changes in the settings hierarchy, but simplifies the changes
necessary outside to support mixed operations of both the old and new kind.
* ~0.8k +/- goes on in generate, which are pretty trivial changes;
* ~0.6k are refactoring the old operations to use the new generators, and is
mostly straightforward; primarily it involves the introduction of a new
PredefinedOperation class, and rewiring the old classes to use its slightly
different methods
* ~.2k are refactoring the new insert/read statements to share the same common
superclass, and use the new partition generator;
* ~.7k are in the settings classes, and are probably the most annoying changes
to review, but also not super important
* the remainder are in the base classes Operation, StressAction and
StressProfile
If this is too painful, I'll see what can be done to split the patch out
further.
> CQL-native stress
> -----------------
>
> Key: CASSANDRA-6146
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6146
> Project: Cassandra
> Issue Type: New Feature
> Components: Tools
> Reporter: Jonathan Ellis
> Assignee: T Jake Luciani
> Fix For: 2.1.1
>
> Attachments: 6146-v2.txt, 6146.txt, 6164-v3.txt
>
>
> The existing CQL "support" in stress is not worth discussing. We need to
> start over, and we might as well kill two birds with one stone and move to
> the native protocol while we're at it.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
