[ 
https://issues.apache.org/jira/browse/CASSANDRA-7523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076793#comment-14076793
 ] 

Joshua McKenzie commented on CASSANDRA-7523:
--------------------------------------------

I ended up going outside scope of strictly C* changes on this while testing - 
here's a snapshot of what I have thus far:
* [cql-internal python driver 
changes|https://github.com/josh-mckenzie/cql-internal/compare/7523]
* [cqlshlib and cqlsh 
changes|https://github.com/josh-mckenzie/cassandra/compare/7523_cqlshlib]
* [Java type 
addition|https://github.com/josh-mckenzie/cassandra/compare/7523_java_types_only]
* [Combined commit, new cql-internal 
archive|https://github.com/josh-mckenzie/cassandra/compare/7523_combined]

A few points I could use some feedback on:
# Is it reasonable to consider the new Date and Time types DATETIME w/regards 
to PEP249?
# What kind of conversion enforcement do we want on SimpleDate and Time types?  
I'm thinking reduction only w/warning on both, promotion to Timestamp w/Date 
object.
# I don't like changing the ui->time_format cqlshrc option underneath people 
but if we add a time type and time_format points to timestamp...

I still have some testing to implement (cqlsh, unit, potentially python driver 
if we merge these changes in) but wanted to get this out there to get feedback 
since this is a new area of the code-base for me.

> add date and time types
> -----------------------
>
>                 Key: CASSANDRA-7523
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7523
>             Project: Cassandra
>          Issue Type: Bug
>          Components: API
>            Reporter: Jonathan Ellis
>            Assignee: Joshua McKenzie
>            Priority: Minor
>             Fix For: 2.0.10
>
>
> http://www.postgresql.org/docs/9.1/static/datatype-datetime.html
> (we already have timestamp; interval is out of scope for now, and see 
> CASSANDRA-6350 for discussion on timestamp-with-time-zone.  but date/time 
> should be pretty easy to add.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to