[
https://issues.apache.org/jira/browse/CASSANDRA-7593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078043#comment-14078043
]
Sylvain Lebresne commented on CASSANDRA-7593:
---------------------------------------------
bq. Assuming EOC.START on RT mins does seem like the correct fix
I definitively disagree btw. I see no reason to do that (outside of the fact
that it happens to fix this very particular issue). No assumptions are made
that a RT should have an EOC for any of its bounds and creating one just feels
wrong.
bq. This fix doesn't address the situation where we legitimately get an sstable
with only range tombstones where the lowerbound has fewer components to the
upper bounds (let's say we have a flood of DELETE from T where pk=K and a > X
and (a,b) < (Y, Z))
Yes, and imo the assumption made by min/max column collection that there is the
same number of component in minColumns and maxColumns in the metadata (the one
that breaks here) is wrong in the first place and we should remove it (make the
code work without that assumption). That said, since we don't currently support
the syntax above, for 2.1.0, we can probably stick to make the fix suggested
above (i.e. make sure we always use the clustering size only in
{{ColumnNameHelper.minComponents}}) as that's pretty simple. Removing the
assumption that both bound of a RT cannot have the same size will have to be
done before CASSANDRA-6237 however.
> Errors when upgrading through several versions to 2.1
> -----------------------------------------------------
>
> Key: CASSANDRA-7593
> URL: https://issues.apache.org/jira/browse/CASSANDRA-7593
> Project: Cassandra
> Issue Type: Bug
> Environment: java 1.7
> Reporter: Russ Hatch
> Assignee: Tyler Hobbs
> Priority: Critical
> Fix For: 2.1.0
>
>
> I'm seeing two different errors cropping up in the dtest which upgrades a
> cluster through several versions.
> This is the more common error:
> {noformat}
> ERROR [GossipStage:10] 2014-07-22 13:14:30,028 CassandraDaemon.java:168 -
> Exception in thread Thread[GossipStage:10,5,main]
> java.lang.AssertionError: null
> at
> org.apache.cassandra.db.filter.SliceQueryFilter.shouldInclude(SliceQueryFilter.java:347)
> ~[main/:na]
> at
> org.apache.cassandra.db.filter.QueryFilter.shouldInclude(QueryFilter.java:249)
> ~[main/:na]
> at
> org.apache.cassandra.db.CollationController.collectAllData(CollationController.java:249)
> ~[main/:na]
> at
> org.apache.cassandra.db.CollationController.getTopLevelColumns(CollationController.java:60)
> ~[main/:na]
> at
> org.apache.cassandra.db.ColumnFamilyStore.getTopLevelColumns(ColumnFamilyStore.java:1873)
> ~[main/:na]
> at
> org.apache.cassandra.db.ColumnFamilyStore.getColumnFamily(ColumnFamilyStore.java:1681)
> ~[main/:na]
> at org.apache.cassandra.db.Keyspace.getRow(Keyspace.java:345)
> ~[main/:na]
> at
> org.apache.cassandra.db.SliceFromReadCommand.getRow(SliceFromReadCommand.java:59)
> ~[main/:na]
> at
> org.apache.cassandra.cql3.statements.SelectStatement.readLocally(SelectStatement.java:293)
> ~[main/:na]
> at
> org.apache.cassandra.cql3.statements.SelectStatement.executeInternal(SelectStatement.java:302)
> ~[main/:na]
> at
> org.apache.cassandra.cql3.statements.SelectStatement.executeInternal(SelectStatement.java:60)
> ~[main/:na]
> at
> org.apache.cassandra.cql3.QueryProcessor.executeInternal(QueryProcessor.java:263)
> ~[main/:na]
> at
> org.apache.cassandra.db.SystemKeyspace.getPreferredIP(SystemKeyspace.java:514)
> ~[main/:na]
> at
> org.apache.cassandra.net.OutboundTcpConnectionPool.<init>(OutboundTcpConnectionPool.java:51)
> ~[main/:na]
> at
> org.apache.cassandra.net.MessagingService.getConnectionPool(MessagingService.java:522)
> ~[main/:na]
> at
> org.apache.cassandra.net.MessagingService.getConnection(MessagingService.java:536)
> ~[main/:na]
> at
> org.apache.cassandra.net.MessagingService.sendOneWay(MessagingService.java:689)
> ~[main/:na]
> at
> org.apache.cassandra.net.MessagingService.sendReply(MessagingService.java:663)
> ~[main/:na]
> at
> org.apache.cassandra.service.EchoVerbHandler.doVerb(EchoVerbHandler.java:40)
> ~[main/:na]
> at
> org.apache.cassandra.net.MessageDeliveryTask.run(MessageDeliveryTask.java:62)
> ~[main/:na]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> ~[na:1.7.0_60]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> ~[na:1.7.0_60]
> at java.lang.Thread.run(Thread.java:745) ~[na:1.7.0_60]
> {noformat}
> The same test sometimes fails with this exception instead:
> {noformat}
> ERROR [CompactionExecutor:4] 2014-07-22 16:18:21,008 CassandraDaemon.java:168
> - Exception in thread Thread[CompactionExecutor:4,1,RMI Runtime]
> java.util.concurrent.RejectedExecutionException: Task
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@7059d3e9
> rejected from
> org.apache.cassandra.concurrent.DebuggableScheduledThreadPoolExecutor@108f1504[Terminated,
> pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 95]
> at
> java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2048)
> ~[na:1.7.0_60]
> at
> java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:821)
> ~[na:1.7.0_60]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:325)
> ~[na:1.7.0_60]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:530)
> ~[na:1.7.0_60]
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.execute(ScheduledThreadPoolExecutor.java:619)
> ~[na:1.7.0_60]
> at
> org.apache.cassandra.io.sstable.SSTableReader.scheduleTidy(SSTableReader.java:628)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.SSTableReader.tidy(SSTableReader.java:609)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.SSTableReader.releaseReference(SSTableReader.java:1596)
> ~[main/:na]
> at
> org.apache.cassandra.db.DataTracker.replaceReaders(DataTracker.java:354)
> ~[main/:na]
> at
> org.apache.cassandra.io.sstable.SSTableRewriter.abort(SSTableRewriter.java:200)
> ~[main/:na]
> at
> org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:192)
> ~[main/:na]
> at
> org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48)
> ~[main/:na]
> at
> org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
> ~[main/:na]
> at
> org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:74)
> ~[main/:na]
> at
> org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59)
> ~[main/:na]
> at
> org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:236)
> ~[main/:na]
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
> ~[na:1.7.0_60]
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> ~[na:1.7.0_60]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> ~[na:1.7.0_60]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> [na:1.7.0_60]
> at java.lang.Thread.run(Thread.java:745) [na:1.7.0_60]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
