[
https://issues.apache.org/jira/browse/CASSANDRA-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107111#comment-14107111
]
sankalp kohli commented on CASSANDRA-5839:
------------------------------------------
Reviewed your patch. Here is the feedback
1) Keyspace name is added at two places. In DatabaseDescriptor and Schema. Why
can't we use one list and use it at both places for cleanup purposes.
2) It should help if we add the exception to the table. This will help in
knowing why repair failed. If it is failing for same reason or different.
3) If there is an exception in RepairSession, it wont be written to this table.
May be we can catch write to table and re throw the exception.
> Save repair data to system table
> --------------------------------
>
> Key: CASSANDRA-5839
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5839
> Project: Cassandra
> Issue Type: New Feature
> Components: Core, Tools
> Reporter: Jonathan Ellis
> Assignee: Marcus Eriksson
> Priority: Minor
> Fix For: 3.0
>
> Attachments: 0001-5839.patch, 2.0.4-5839-draft.patch,
> 2.0.6-5839-v2.patch
>
>
> As noted in CASSANDRA-2405, it would be useful to store repair results,
> particularly with sub-range repair available (CASSANDRA-5280).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
