[ https://issues.apache.org/jira/browse/CAY-1841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13744130#comment-13744130 ]
Andrus Adamchik commented on CAY-1841: -------------------------------------- I committed Ilya's patch (just removed changes related to DataMap preferences additions that don't seem relevant here). Looks pretty cool, though a few suggestions/observations: 1. Maybe we should use a toolbar similar to what we have on the right side to organize the buttons. 2. When clicking collapse button ("-"), I suggest keeping the second level - a list of DataMaps - open. It is enough to collapse everything under them (at least until we implement multi-project tree) 3. Do we need "Expand tree" button? Eclipse doesn't have it and I doubt it is very useful. Maybe just keep "Collapse tree" and "Filter" 4. Filter checkboxes are not unchecked when I select any of the object types... The filter works, but it is impossible to tell what is currently filtered. 5. Select All / Unselect All... First I'd change the wording to "Hide All/Show All". Also just like with Expand/Collapse, I suspect we'll only need one option - "Show All". "Hide All" is kind of evil :) > Filters for Left-hand project navigator (kind of like Eclipse panel filters) > to show/hide everything/objentities/dbentities/queries > ------------------------------------------------------------------------------------------------------------------------------------ > > Key: CAY-1841 > URL: https://issues.apache.org/jira/browse/CAY-1841 > Project: Cayenne > Issue Type: Improvement > Components: Modeler > Affects Versions: 3.1M2, 3.2M1 > Reporter: Kravchenko > Attachments: 1841new.txt, 1841.txt, CAY-1841_fixed, Filter.ogv, > icon-filter.png, icon-tree-collapse.png, icon-tree-expand.png, patch.txt > > Original Estimate: 20h > Remaining Estimate: 20h > > In this path created filter-dialog for Filters for left-hand project > navigator. It is allows show and hide needed attributes. You can see this in > video clip. But necessary upgrade graphic part of this task ss. upgrade > dialog frame and filter button. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira