[
https://issues.apache.org/jira/browse/CAY-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrus Adamchik closed CAY-2134.
--------------------------------
Resolution: Won't Fix
this may still be a useful refactoring; I just ran out of time on this work.
Our DbImport pipeline is already much cleaner as a result of the recent work.
But this one has to be postponed/canceled.
> Refactor DbImportAction to fully use DI
> ---------------------------------------
>
> Key: CAY-2134
> URL: https://issues.apache.org/jira/browse/CAY-2134
> Project: Cayenne
> Issue Type: Improvement
> Reporter: Andrus Adamchik
> Assignee: Andrus Adamchik
>
> We won't be able to implement CAY-2130 or any similar tasks until we clean up
> the flow and switch everything to dependency injection. Some ideas:
> * Injector scope will be a single action... Injector will be started after
> configuration is complete. This way DI services can be aware of the available
> parameters (and e.g. provide a custom implementation for this or that
> service).
> * Make DbImportConfiguration immutable and store it in DI. Without it we
> can't seed DI with the right implementors.
> * Redo the whole ModelerDbImportAction. The way it is done now, it is
> impossible to refactor anything DbImport-related. It should also benefit from
> DI - we can provide Modeler-specific ProjectSaver instead of doing
> subclassing and wrapping DefaultDbImportAction
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
