stariy95 commented on code in PR #627:
URL: https://github.com/apache/cayenne/pull/627#discussion_r1981049296
##########
cayenne-server/src/main/java/org/apache/cayenne/access/ObjectStore.java:
##########
@@ -201,7 +205,7 @@ synchronized ObjectDiff registerDiff(Object nodeId,
NodeDiff diff) {
}
}
- objectDiff = new ObjectDiff(object);
+ objectDiff = new ObjectDiff(persistentWrapper);
Review Comment:
Yes, though it's not obviuos. Diff must hold a reference to the ObjectStore
internal state object, as otherwise it may be deleted by the GC from the
Weak/Soft reference map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
