[incubator-celeborn] branch main updated: [CELEBORN-155] Wrong TimeUnit for registerShuffleRetryWait in Shuffle… (#1099)

[zhouky]

This is an automated email from the ASF dual-hosted git repository.

zhouky pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new a2dd72f2 [CELEBORN-155] Wrong TimeUnit for registerShuffleRetryWait in 
Shuffle… (#1099)
a2dd72f2 is described below

commit a2dd72f20ceb8dfe2ed0c71ef1217de5d10ca04f
Author: Keyong Zhou <zho...@apache.org>
AuthorDate: Mon Dec 19 17:32:18 2022 +0800

    [CELEBORN-155] Wrong TimeUnit for registerShuffleRetryWait in Shuffle… 
(#1099)
---
 .../src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java | 6 +++---
 common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git 
a/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java 
b/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
index 103eac13..a7193d03 100644
--- a/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
+++ b/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java
@@ -82,7 +82,7 @@ public class ShuffleClientImpl extends ShuffleClient {
   private final UserIdentifier userIdentifier;
 
   private final int registerShuffleMaxRetries;
-  private final long registerShuffleRetryWait;
+  private final long registerShuffleRetryWaitMs;
   private int maxInFlight;
   private Integer currentMaxReqsInFlight = 1;
   private int congestionAvoidanceFlag = 0;
@@ -136,7 +136,7 @@ public class ShuffleClientImpl extends ShuffleClient {
     this.conf = conf;
     this.userIdentifier = userIdentifier;
     registerShuffleMaxRetries = conf.registerShuffleMaxRetry();
-    registerShuffleRetryWait = conf.registerShuffleRetryWait();
+    registerShuffleRetryWaitMs = conf.registerShuffleRetryWaitMs();
     maxInFlight = conf.pushMaxReqsInFlight();
     pushBufferMaxSize = conf.pushBufferMaxSize();
 
@@ -345,7 +345,7 @@ public class ShuffleClientImpl extends ShuffleClient {
       }
 
       try {
-        TimeUnit.SECONDS.sleep(registerShuffleRetryWait);
+        TimeUnit.MILLISECONDS.sleep(registerShuffleRetryWaitMs);
       } catch (InterruptedException e) {
         break;
       }
diff --git 
a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala 
b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
index f5d87b86..16b078ba 100644
--- a/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
+++ b/common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
@@ -520,7 +520,7 @@ class CelebornConf(loadDefaults: Boolean) extends Cloneable 
with Logging with Se
   def shuffleManagerPort: Int = get(SHUFFLE_MANAGER_PORT)
   def shuffleChunkSize: Long = get(SHUFFLE_CHUCK_SIZE)
   def registerShuffleMaxRetry: Int = get(SHUFFLE_REGISTER_MAX_RETRIES)
-  def registerShuffleRetryWait: Long = get(SHUFFLE_REGISTER_RETRY_WAIT)
+  def registerShuffleRetryWaitMs: Long = get(SHUFFLE_REGISTER_RETRY_WAIT)
   def reserveSlotsMaxRetries: Int = get(RESERVE_SLOTS_MAX_RETRIES)
   def reserveSlotsRetryWait: Long = get(RESERVE_SLOTS_RETRY_WAIT)
   def rpcMaxParallelism: Int = get(CLIENT_RPC_MAX_PARALLELISM)