This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new 16d9c657c [CELEBORN-805][FOLLOWUP] Remove unnecessary TODO
16d9c657c is described below
commit 16d9c657c2b0605d8708a62392bb10b98749b2aa
Author: Fu Chen <[email protected]>
AuthorDate: Tue Jul 18 13:37:21 2023 +0800
[CELEBORN-805][FOLLOWUP] Remove unnecessary TODO
### What changes were proposed in this pull request?
As title
### Why are the changes needed?
cleanup the unnecessary TODO which introduced in
https://github.com/apache/incubator-celeborn/pull/1727
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Review
Closes #1728 from cfmcgrady/shutdown.
Authored-by: Fu Chen <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
---
.../main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala | 1 -
1 file changed, 1 deletion(-)
diff --git
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
index 0ad8b5d0b..37174b2c0 100644
---
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
+++
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala
@@ -438,7 +438,6 @@ private[celeborn] class Worker(
masterClient.close()
replicateServer.shutdown(graceful)
fetchServer.shutdown(graceful)
- // TODO: `pushServer` never be closed before this PR.
pushServer.shutdown(graceful)
super.shutdown(graceful)