This is an automated email from the ASF dual-hosted git repository.
ethanfeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new c0dda4a15 [CELEBORN-1240][FOLLOWUP] Introduce web profile for web
module
c0dda4a15 is described below
commit c0dda4a15aa988ba1dca9437573bb8aed8c1554c
Author: SteNicholas <[email protected]>
AuthorDate: Tue Aug 27 15:00:52 2024 +0800
[CELEBORN-1240][FOLLOWUP] Introduce web profile for web module
### What changes were proposed in this pull request?
Introduce web profile for web module.
### Why are the changes needed?
The compilation speed of web module is sometimes very slow due to the
influence of the network, which hinders the development process.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI.
Closes #2679 from SteNicholas/CELEBORN-1240.
Authored-by: SteNicholas <[email protected]>
Signed-off-by: mingji <[email protected]>
---
pom.xml | 8 +++++++-
project/CelebornBuild.scala | 23 ++++++++++++++++++++++-
2 files changed, 29 insertions(+), 2 deletions(-)
diff --git a/pom.xml b/pom.xml
index 205e3ce2d..f123201f8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -38,7 +38,6 @@
<module>service</module>
<module>master</module>
<module>worker</module>
- <module>web</module>
</modules>
<distributionManagement>
@@ -1764,6 +1763,13 @@
</modules>
</profile>
+ <profile>
+ <id>web</id>
+ <modules>
+ <module>web</module>
+ </modules>
+ </profile>
+
<profile>
<id>google-mirror</id>
<properties>
diff --git a/project/CelebornBuild.scala b/project/CelebornBuild.scala
index eed2f5964..5ac4fc544 100644
--- a/project/CelebornBuild.scala
+++ b/project/CelebornBuild.scala
@@ -355,7 +355,7 @@ object CelebornBuild extends sbt.internal.BuildDef {
CelebornClient.client,
CelebornService.service,
CelebornWorker.worker,
- CelebornMaster.master) ++ maybeSparkClientModules ++
maybeFlinkClientModules ++ maybeMRClientModules
+ CelebornMaster.master) ++ maybeSparkClientModules ++
maybeFlinkClientModules ++ maybeMRClientModules ++ maybeWebModules
}
// ThisBuild / parallelExecution := false
@@ -422,6 +422,15 @@ object Utils {
lazy val maybeMRClientModules: Seq[Project] =
mrClientProjects.map(_.modules).getOrElse(Seq.empty)
+ val WEB_VERSION = profiles.filter(_.startsWith("web")).headOption
+
+ lazy val webProjects = WEB_VERSION match {
+ case Some("web") => Some(WebProjects)
+ case _ => None
+ }
+
+ lazy val maybeWebModules: Seq[Project] =
webProjects.map(_.modules).getOrElse(Seq.empty)
+
def defaultScalaVersion(): String = {
// 1. Inherit the scala version of the spark project
// 2. if the spark profile not specified, using the DEFAULT_SCALA_VERSION
@@ -1432,3 +1441,15 @@ object CelebornOpenApi {
pomPostProcess := removeDependenciesTransformer
)
}
+
+object WebProjects {
+
+ def web: Project = {
+ Project("celeborn-web", file("web"))
+ .settings(commonSettings)
+ }
+
+ def modules: Seq[Project] = {
+ Seq(web)
+ }
+}
