This is an automated email from the ASF dual-hosted git repository.
ethanfeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/main by this push:
new d5645a98d [CELEBORN-1900][FOLLOWUP] use github actions to login to
docker hub
d5645a98d is described below
commit d5645a98d72f21d8f8493ec87bd09697c5845979
Author: Björn Boschman <[email protected]>
AuthorDate: Tue Mar 25 19:58:53 2025 +0800
[CELEBORN-1900][FOLLOWUP] use github actions to login to docker hub
### What changes were proposed in this pull request?
use correct docker secrets
### Why are the changes needed?
use github actions to login to docker hub
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Can test this patch because the forked repo does not have docker secrets.
Closes #3168 from jesusch/CELEBORN-1900-docker-images-fix-2.
Authored-by: Björn Boschman <[email protected]>
Signed-off-by: mingji <[email protected]>
---
.github/workflows/docker-build.yml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/docker-build.yml
b/.github/workflows/docker-build.yml
index cbdd25acd..ecff32f60 100644
--- a/.github/workflows/docker-build.yml
+++ b/.github/workflows/docker-build.yml
@@ -32,10 +32,15 @@ jobs:
wget
https://downloads.apache.org/celeborn/celeborn-${VERSION}/apache-celeborn-${VERSION}-bin.tgz
tar -xzf apache-celeborn-${VERSION}-bin.tgz
+ - name: Login to Docker Hub
+ uses: docker/login-action@v3
+ with:
+ username: ${{ secrets.DOCKERHUB_USER }}
+ password: ${{ secrets.DOCKERHUB_TOKEN }}
+
- name: Build and Push
run: |
VERSION="${{ steps.set_version.outputs.VERSION }}"
cd apache-celeborn-${VERSION}-bin
- docker login -u ${{ secrets.DOCKER_USERNAME }} -p ${{
secrets.DOCKER_PASSWORD }}
docker buildx create --use
docker buildx build -f docker/Dockerfile
--platform=linux/amd64,linux/arm64 -t apache/celeborn:${VERSION} .
