This is an automated email from the ASF dual-hosted git repository.
nicholasjiang pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/branch-0.6 by this push:
new e25c18180 [CELEBORN-2125] Imporve PartitionFilesSorter sort timeout log
e25c18180 is described below
commit e25c18180750b4e5d7d2bf8070b09e93d5239b98
Author: sychen <[email protected]>
AuthorDate: Tue Aug 26 19:23:22 2025 +0800
[CELEBORN-2125] Imporve PartitionFilesSorter sort timeout log
### What changes were proposed in this pull request?
### Why are the changes needed?
log only outputs fileid, exception only has file path, and no file length.
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
```
25/08/25 18:06:37,083 ERROR [pool-1-thread-1] PartitionFilesSorter: Sorting
file
application-1-/var/folders/tc/r2n_8g6j4731h7clfqwntg880000gn/T/Celeborn1344631182030527062sort-suite
path
/var/folders/tc/r2n_8g6j4731h7clfqwntg880000gn/T/Celeborn1344631182030527062sort-suite
length 2453444321 timeout after 1ms
```
Closes #3446 from cxzl25/CELEBORN-2125.
Authored-by: sychen <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
(cherry picked from commit 679df6c0f5d58217b19f3f85fb89a15c73182d60)
Signed-off-by: SteNicholas <[email protected]>
---
.../service/deploy/worker/storage/PartitionFilesSorter.java | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git
a/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java
b/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java
index a2c833ee8..55ff7cc83 100644
---
a/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java
+++
b/worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorter.java
@@ -271,9 +271,15 @@ public class PartitionFilesSorter extends
ShuffleRecoverHelper {
try {
Thread.sleep(50);
if (System.currentTimeMillis() - sortStartTime > sortTimeout) {
- logger.error("Sorting file {} timeout after {}ms", fileId,
sortTimeout);
- throw new IOException(
- "Sort file " + diskFileInfo.getFilePath() + " timeout
after " + sortTimeout);
+ String msg =
+ String.format(
+ "Sorting file %s path %s length %s timeout after %dms",
+ fileId,
+ diskFileInfo.getFilePath(),
+ diskFileInfo.getFileLength(),
+ sortTimeout);
+ logger.error(msg);
+ throw new IOException(msg);
}
} catch (InterruptedException e) {
logger.error(