(celeborn) branch main updated: [CELEBORN-2164] Fix incorrect filtering conditions in updateDiskInfos

[nicholasjiang]

This is an automated email from the ASF dual-hosted git repository.

nicholasjiang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/celeborn.git


The following commit(s) were added to refs/heads/main by this push:
     new 2fbac7b30 [CELEBORN-2164] Fix incorrect filtering conditions in 
updateDiskInfos
2fbac7b30 is described below

commit 2fbac7b302d37d38ad99345b607b05df880a25a0
Author: xxx <953396...@qq.com>
AuthorDate: Fri Oct 10 15:16:38 2025 +0800

    [CELEBORN-2164] Fix incorrect filtering conditions in updateDiskInfos
    
    ### What changes were proposed in this pull request?
    
    Fix incorrect filtering conditions in `updateDiskInfos`
    
    ### Why are the changes needed?
    
    This condition uses the logical OR (||) operator, but it will actually 
match all disks because no disk's status can be equal to both `IO_HANG` and 
`READ_OR_WRITE_FAILURE` at the same time.
    
    ### Does this PR introduce _any_ user-facing change?
    
    NO
    
    ### How was this patch tested?
    
    CI
    
    Closes #3494 from xy2953396112/CELEBORN-2164.
    
    Authored-by: xxx <953396...@qq.com>
    Signed-off-by: SteNicholas <programg...@163.com>
---
 .../apache/celeborn/service/deploy/worker/storage/StorageManager.scala  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
 
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
index 43eb3ca17..f68c64168 100644
--- 
a/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
+++ 
b/worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala
@@ -910,7 +910,7 @@ final private[worker] class StorageManager(conf: 
CelebornConf, workerSource: Abs
   def updateDiskInfos(): Unit = this.synchronized {
     disksSnapshot()
       .filter(diskInfo =>
-        diskInfo.status != DiskStatus.IO_HANG || diskInfo.status != 
DiskStatus.READ_OR_WRITE_FAILURE)
+        diskInfo.status != DiskStatus.IO_HANG && diskInfo.status != 
DiskStatus.READ_OR_WRITE_FAILURE)
       .foreach {
         diskInfo =>
           val totalUsage = diskInfo.dirs.map { dir =>