This is an automated email from the ASF dual-hosted git repository.
nicholasjiang pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/celeborn.git
The following commit(s) were added to refs/heads/branch-0.6 by this push:
new 51c4123ea [CELEBORN-2203] Set celeborn.master.internal.endpoints in
the configmap
51c4123ea is described below
commit 51c4123ea65776012ec58cdb178e8cfa2459fe35
Author: Ping Zhang <[email protected]>
AuthorDate: Mon Nov 17 10:54:29 2025 +0800
[CELEBORN-2203] Set celeborn.master.internal.endpoints in the configmap
### What changes were proposed in this pull request?
Set `celeborn.master.internal.endpoints` in the configmap.
### Why are the changes needed?
The default value is `<localhost>:8097` right now, which cause that workers
fail to start as it cannot connect to that port.
### Does this PR resolve a correctness bug?
No.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
<img width="2732" height="1104" alt="image"
src="https://github.com/user-attachments/assets/542b6554-61c1-4c7b-a7bc-718cdcd50176";
/>
Closes #3536 from pingzh/dev/pingz-celeborn.master.internal.endpoints.
Authored-by: Ping Zhang <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
(cherry picked from commit b6789915b8c20ab7457a16ccea290a360f49845e)
Signed-off-by: SteNicholas <[email protected]>
---
charts/celeborn/templates/configmap.yaml | 2 ++
charts/celeborn/tests/configmap_test.yaml | 6 ++++++
2 files changed, 8 insertions(+)
diff --git a/charts/celeborn/templates/configmap.yaml
b/charts/celeborn/templates/configmap.yaml
index c838294f6..e412af41d 100644
--- a/charts/celeborn/templates/configmap.yaml
+++ b/charts/celeborn/templates/configmap.yaml
@@ -32,6 +32,8 @@ data:
{{- end }}
celeborn.master.endpoints={{ $endpoints | join "," }}
+ celeborn.master.internal.endpoints = {{ $endpoints | join "," }}
+
{{- range until (.Values.master.replicas | int) }}
{{- $host := (printf "%s-%d.%s.%s.svc.%s.local" (include
"celeborn.master.statefulSet.name" $) . (include "celeborn.master.service.name"
$) $.Release.Namespace $.Values.cluster.name) }}
celeborn.master.ha.node.{{ . }}.host={{ $host }}
diff --git a/charts/celeborn/tests/configmap_test.yaml
b/charts/celeborn/tests/configmap_test.yaml
index 0d8128665..28b793a16 100644
--- a/charts/celeborn/tests/configmap_test.yaml
+++ b/charts/celeborn/tests/configmap_test.yaml
@@ -38,3 +38,9 @@ tests:
path: data["celeborn-defaults.conf"]
- exists:
path: data["log4j2.xml"]
+
+ - it: Should include celeborn.master.internal.endpoints key in
celeborn-defaults.conf
+ asserts:
+ - matchRegex:
+ path: data["celeborn-defaults.conf"]
+ pattern: "(?m)^\\s*celeborn\\.master\\.internal\\.endpoints\\s*=.*"
