[ 
https://issues.apache.org/jira/browse/CELIX-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051076#comment-15051076
 ] 

Bjoern Petri commented on CELIX-320:
------------------------------------

I applied your patch, thanks for the work. I also enabled the tests within the 
travis cfg. Please close if okay.

> outdated utils tests (threads, hashmap)
> ---------------------------------------
>
>                 Key: CELIX-320
>                 URL: https://issues.apache.org/jira/browse/CELIX-320
>             Project: Celix
>          Issue Type: Improvement
>          Components: Utils
>            Reporter: Menno van der Graaf
>            Priority: Minor
>         Attachments: utils_tests_threads_hashmap_cmakelist_fixed.patch
>
>
> the celix_threads tests are outdated/missing: no tests for the r/w-lock, no 
> test for the thread_kill
> there is a compile warning in the hashmap tests: comparing the pointer of a 
> function pointer, instead of the function pointer itself
> the utils CMakeList is incorrect: some old statements still commented, the 
> new celix_threads tests require an extra library linked, the option 
> "UTILS-TESTS" is declared but not used



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to