This is an automated email from the ASF dual-hosted git repository. maxyang pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit bbc8cc30985730961ba0c65c4bda13119b09022d Author: xuejing zhao <[email protected]> AuthorDate: Thu Mar 31 17:52:45 2022 +0800 resolve update distributed key with oids fixme (#13343) In the older version we can create table with (oids=true); therefore, each row has an OID, when we update distributed columns of a table, a row may move from one segment to another one. so we must ensure that the target list contains the old OID so that the Split Update can copy it to the new tuple. but the newest version of GPDB does not support create table with (oids=true). when merging postgres12, the logic of codes is removed by this commit: https://github.com/greenplum-db/gpdb-postgres-merge/commit/7c3bd14c32a746c8f8a3e59898d8e587638054fb But the comments remain. Now we remove related comments also. we just modify comments, so there is no test case. --- src/backend/optimizer/prep/preptlist.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/backend/optimizer/prep/preptlist.c b/src/backend/optimizer/prep/preptlist.c index 8925a54b37..a25f62448e 100644 --- a/src/backend/optimizer/prep/preptlist.c +++ b/src/backend/optimizer/prep/preptlist.c @@ -517,16 +517,7 @@ check_splitupdate(List *tlist, Index result_relation, Relation rel) /* * If an UPDATE can move the tuples from one segment to another, we will * need to create a Split Update node for it. The node is created later - * in the planning, but if it's needed, and the table has OIDs, we must - * ensure that the target list contains the old OID so that the Split - * Update can copy it to the new tuple. - * - * GPDB_96_MERGE_FIXME: we used to copy all old distribution key columns, - * but we only need this for the OID now. Can we desupport Split Updates - * on tables with OIDs, and get rid of this? - * - * GPDB_12_MERGE_FIXME: Tables with special OIDS is now gone. We can - * definitely get rid of this now. + * in the planning. */ { GpPolicy *targetPolicy; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
