This is an automated email from the ASF dual-hosted git repository. maxyang pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 8fb316acec195e2651ad3e2289c55ab65ff56c3c Author: Wenlin Zhang <[email protected]> AuthorDate: Fri Jul 15 10:53:34 2022 +0800 Remove fixme comment in aset.c:AllocSetTransferAccounting. (#13786) As AllocSetTransferAccounting() was called during MemoryContextSetParent(). Before update the memory accouting info, it asserts MemoryContextIsValid(), which includes AllocSetContext, SlabContext and GenerationContext. Currently, there is no mixed context situation and other context doesn't have the accounting info, so I think it's ok to remove the comment. --- src/backend/utils/mmgr/aset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/mmgr/aset.c b/src/backend/utils/mmgr/aset.c index b183f7e32c..05177a3ede 100644 --- a/src/backend/utils/mmgr/aset.c +++ b/src/backend/utils/mmgr/aset.c @@ -1681,8 +1681,8 @@ void AllocSetTransferAccounting(MemoryContext context, MemoryContext new_parent) { /* - * Mixing AllocSetContexts and other contexts parent will lose the accounting info. - */ + * Mixing AllocSetContexts and other contexts will lose the accounting info. + */ if (!IsA(context, AllocSetContext) || (new_parent != NULL && !IsA(new_parent, AllocSetContext))) return; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
