This is an automated email from the ASF dual-hosted git repository.

maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit c9f44457d6c0a0664a7c749c6384e048946a978f
Author: David Kimura <[email protected]>
AuthorDate: Mon Sep 19 21:01:20 2022 +0000

    Add exception using unsupported default comparator evaulator types
---
 src/backend/gporca/libgpopt/src/base/CDefaultComparator.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/backend/gporca/libgpopt/src/base/CDefaultComparator.cpp 
b/src/backend/gporca/libgpopt/src/base/CDefaultComparator.cpp
index 63d5a6bf04..11be5f18ef 100644
--- a/src/backend/gporca/libgpopt/src/base/CDefaultComparator.cpp
+++ b/src/backend/gporca/libgpopt/src/base/CDefaultComparator.cpp
@@ -124,7 +124,11 @@ CDefaultComparator::FUseInternalEvaluator(const IDatum 
*datum1,
                return true;
        }
 
-       // GPDB_12_MERGE_FIXME: Throw an exception when result = false and 
can_use_external_evaluator = false
+       if (!can_use_external_evaluator)
+       {
+               GPOS_RAISE(gpopt::ExmaGPOPT, gpopt::ExmiUnsupportedOp,
+                                  GPOS_WSZ_LIT("Unsupported comparator 
evaluator for types"));
+       }
 
        return false;
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to