This is an automated email from the ASF dual-hosted git repository.

maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit 03732b43730a9433c7d7f6c000b1e7748f3d9147
Author: Jingyu Wang <[email protected]>
AuthorDate: Fri Jan 20 15:56:43 2023 -0800

    Remove inaccurate FIXME message
    
    Fixme:
    src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp:
    // GPDB_12_MERGE_FIXME: this duplicates a check in ExecInitProjectSet
    
    Action:
    None. Function SanityCheckProjectSetTargetList share some code with
    ExecInitProjectSet. But refactoring isn't trivial and will involve changes 
to
    upstream .c files. This check will be removed after PR #14302 is merged. For
    now, remove the FIXME tag to avoid confusion.
---
 src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp 
b/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp
index efef8d4ff3..0a9737ebc1 100644
--- a/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp
+++ b/src/backend/gpopt/translate/CTranslatorDXLToPlStmt.cpp
@@ -3319,7 +3319,6 @@ ContainsSetReturningFuncOrOp(const CDXLNode 
*project_list_dxlnode,
        return false;
 }
 
-// GPDB_12_MERGE_FIXME: this duplicates a check in ExecInitProjectSet
 static bool
 SanityCheckProjectSetTargetList(List *targetlist)
 {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to