This is an automated email from the ASF dual-hosted git repository.

maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit f917aa344681029d2b73d7324b5265f80f1942e8
Author: Yongtao Huang <[email protected]>
AuthorDate: Fri Jun 16 19:16:44 2023 +0800

    Remove FIXME in relation_open() (#15786)
    
    Long log:
    
    The error and errdetail are both valid. Please refer to
    [issue 15095](https://github.com/greenplum-db/gpdb/issues/15095).
    
    The mini repo below will trigger this errdetail
    ```
    create table t1(c1 int);
    create temporary table t2(c1 int);
    create index i0 on t1(c1);
    create index i0 on t2(c1);
    discard all;
    drop index i0;
    vacuum t1;
    ```
    So revome this fixme.
    
    Signed-off-by: Yongtao Huang <[email protected]>
---
 src/backend/access/common/relation.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/backend/access/common/relation.c 
b/src/backend/access/common/relation.c
index fb3f53b717..3b6ac578a1 100644
--- a/src/backend/access/common/relation.c
+++ b/src/backend/access/common/relation.c
@@ -58,7 +58,6 @@ relation_open(Oid relationId, LOCKMODE lockmode)
        /* The relcache does all the real work... */
        r = RelationIdGetRelation(relationId);
 
-       /* GPDB_12_AFTER_MERGE_FIXME: We had added the errdetail in GPDB. Is it 
still valid? */
        if (!RelationIsValid(r))
                ereport(ERROR,
                                (errcode(ERRCODE_UNDEFINED_TABLE),


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to