This is an automated email from the ASF dual-hosted git repository. yjhjstz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudberry.git
commit 8ca05e6a20fe9be1f5ecef4e58c140a34a99f9fa Author: Brent Doil <[email protected]> AuthorDate: Fri Jan 5 15:46:14 2024 -0500 Add spaces before pg_ctl args in pg_upgrade code. This guarentees the arguments are treated as separate instances in all cases. Prior to this change, some startup parameters may be concatenated together, causing pg_ctl startup to fail. --- src/bin/pg_upgrade/server.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/pg_upgrade/server.c b/src/bin/pg_upgrade/server.c index a39bec47b0..7e6dd3f6ab 100644 --- a/src/bin/pg_upgrade/server.c +++ b/src/bin/pg_upgrade/server.c @@ -255,15 +255,15 @@ start_postmaster(ClusterInfo *cluster, bool report_and_exit_on_error) */ char *version_opts = ""; if (GET_MAJOR_VERSION(cluster->major_version) >= 904) - version_opts = "-c synchronous_standby_names='' --xid_warn_limit=10000000"; + version_opts = " -c synchronous_standby_names='' --xid_warn_limit=10000000"; else { if (is_greenplum_dispatcher_mode()) version_opts = - "-c gp_dbid=1 -c gp_contentid=-1 -c gp_num_contents_in_cluster=1"; + " -c gp_dbid=1 -c gp_contentid=-1 -c gp_num_contents_in_cluster=1"; else version_opts = - "-c gp_dbid=1 -c gp_contentid=0 -c gp_num_contents_in_cluster=1"; + " -c gp_dbid=1 -c gp_contentid=0 -c gp_num_contents_in_cluster=1"; } snprintf(cmd, sizeof(cmd), --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
