tuhaihe commented on code in PR #1151:
URL: https://github.com/apache/cloudberry/pull/1151#discussion_r2139098036


##########
configure.ac:
##########


Review Comment:
   > > > but I test use gcc-9 , it works ok.
   > > 
   > > 
   > > With a lower GCC version, there may be numerous warnings during 
compilation and installation. Have you experienced this? I will test it later.
   > 
   > no experienced. But limit gcc version >= 11 is not good idea. We suggest 
test c++ features like `-std=c++14`.
   
   Cool. I tested with g++ 9.2.1 and the build was successful. With g++ 8.5.0, 
it will still fail to build the PAX-related modules (googlebench).
   
   So for the g++ version check, we can ask gcc 9+ version installed at least. 
How does it make sense?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cloudberry.apache.org
For additional commands, e-mail: commits-h...@cloudberry.apache.org

Reply via email to