my-ship-it commented on code in PR #1173:
URL: https://github.com/apache/cloudberry/pull/1173#discussion_r2163655046
##########
src/backend/cdb/cdbgroupingpaths.c:
##########
@@ -700,6 +712,24 @@ create_two_stage_paths(PlannerInfo *root,
cdb_agg_planning_context *ctx,
if (path == cheapest_path || is_sorted)
add_first_stage_group_agg_path(root, path,
is_sorted, ctx);
}
+
+ if (ctx->is_distinct && partial_pathlist)
+ {
+ foreach(lc, partial_pathlist)
+ {
+ Path *path = (Path *) lfirst(lc);
+ bool is_sorted;
+
+ if (cdbpathlocus_collocates_tlist(root,
path->locus, ctx->group_tles))
Review Comment:
Does cdbpathlocus_collocates_tlist always returns false for HashedWorkers?
##########
src/backend/cdb/cdbgroupingpaths.c:
##########
@@ -700,6 +712,24 @@ create_two_stage_paths(PlannerInfo *root,
cdb_agg_planning_context *ctx,
if (path == cheapest_path || is_sorted)
add_first_stage_group_agg_path(root, path,
is_sorted, ctx);
}
+
+ if (ctx->is_distinct && partial_pathlist)
+ {
+ foreach(lc, partial_pathlist)
+ {
+ Path *path = (Path *) lfirst(lc);
+ bool is_sorted;
+
+ if (cdbpathlocus_collocates_tlist(root,
path->locus, ctx->group_tles))
Review Comment:
Does cdbpathlocus_collocates_tlist always return false for HashedWorkers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
