edespino commented on code in PR #25:
URL:
https://github.com/apache/cloudberry-devops-release/pull/25#discussion_r2166226967
##########
images/docker/cbdb/build/rocky9/Dockerfile:
##########
@@ -138,7 +138,7 @@ RUN dnf makecache && \
libyaml-devel \
perl-IPC-Run \
protobuf-devel && \
- dnf clean all && \
+ dnf clean all && rm -rf /var/cache/dnf/* && \
Review Comment:
Maybe amend the commit message with the following which describes this
change.
Purpose of rm -rf /var/cache/dnf/*
Even though dnf clean all should remove the contents of /var/cache/dnf/,
this extra rm step is:
* A failsafe/manual cleanup, in case DNF leaves anything behind (e.g. due to
bugs or distro version differences).
* Common in slim or hardened images to ensure absolutely no cache data
remains.
##########
images/docker/cbdb/build/rocky8/Dockerfile:
##########
@@ -87,8 +87,8 @@ RUN dnf makecache && \
diffutils \
file \
flex \
- gcc-toolset-11-gcc \
- gcc-toolset-11-gcc-c++ \
+ gcc \
Review Comment:
Please consider amending the commit message to include the default GCC
version on Rocky Linux 8. I believe GCC 8.5.0 is used:
```
$ rpm -aq | grep gcc
gcc-8.5.0-26.el8_10.x86_64
gcc-c++-8.5.0-26.el8_10.x86_64
gcc-plugin-annobin-8.5.0-26.el8_10.x86_64
libgcc-8.5.0-26.el8_10.x86_64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
